docs(core): correct type for opts.read #37626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
reviewed
Jun 17, 2020
The ContentChildren decorator has a metadata property named "read" which can be used to read a different token from the queried elements. The documentation incorrectly says "True to read..." when it should say "Used to read...".
atscott
approved these changes
Jun 18, 2020
mhevery
pushed a commit
that referenced
this pull request
Jun 18, 2020
The ContentChildren decorator has a metadata property named "read" which can be used to read a different token from the queried elements. The documentation incorrectly says "True to read..." when it should say "Used to read...". PR Close #37626
ngwattcos
pushed a commit
to ngwattcos/angular
that referenced
this pull request
Jun 25, 2020
The ContentChildren decorator has a metadata property named "read" which can be used to read a different token from the queried elements. The documentation incorrectly says "True to read..." when it should say "Used to read...". PR Close angular#37626
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
The ContentChildren decorator has a metadata property named "read" which can be used to read a different token from the queried elements. The documentation incorrectly says "True to read..." when it should say "Used to read...". PR Close angular#37626
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We have 4 decorators: ViewChild, ViewChildren, ContentChild, ContentChildren. They have accept extra info to read a token, but the typing for
opts.readis not correct. It set to Boolean right now.Issue Number: N/A
What is the new behavior?
Correct type of
opts.readto any.Does this PR introduce a breaking change?
Other information